----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38461/#review101331 -----------------------------------------------------------
Direct plugin call never worked for ambari metrics. It uses profiles with property activation as Sid mentioned above. This allowed us to correctly package multiple modules into sinlge rpm/deb package without using stub plugin definitions. And this is a reason why metrics module was excluded from ambari build. It had to be build separately. But then it was included into general build and stubs still came here (for rpms at least). But it doesn't generate packages. Looks ok as a workaround though. IMO we should move to profiles instead of direct plugin invocation for Ambari build also in future. This will allow to clean up some garbage from pom files. - Myroslav Papirkovskyy On Вер. 18, 2015, 1:58 після полудня, Canan Girgin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38461/ > ----------------------------------------------------------- > > (Updated Вер. 18, 2015, 1:58 після полудня) > > > Review request for Ambari, John Speidel, Nate Cole, Srimanth Gunturi, and Sid > Wagle. > > > Bugs: AMBARI-12977 > https://issues.apache.org/jira/browse/AMBARI-12977 > > > Repository: ambari > > > Description > ------- > > running "mvn -B clean install package jdeb:jdeb -DskipTests > -Dpython.ver="python >= 2.6" -Preplaceurl" command on ambari directory, shows > failure caused by problems during dep packaging. if want to package only > ambari-metrics and run command on ambari-metrics directory everything is ok. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-flume-sink/pom.xml 058edfa > ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 08de87d > ambari-metrics/ambari-metrics-host-monitoring/pom.xml 746949b > ambari-metrics/ambari-metrics-kafka-sink/pom.xml 44423a2 > ambari-metrics/ambari-metrics-storm-sink/pom.xml 138f712 > ambari-metrics/ambari-metrics-timelineservice/pom.xml a630fcc > > Diff: https://reviews.apache.org/r/38461/diff/ > > > Testing > ------- > > > Thanks, > > Canan Girgin > >
