----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39051/#review101636 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Жов. 6, 2015, 11:54 до полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39051/ > ----------------------------------------------------------- > > (Updated Жов. 6, 2015, 11:54 до полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-13322 > https://issues.apache.org/jira/browse/AMBARI-13322 > > > Repository: ambari > > > Description > ------- > > When running w/o internet, Ambari will not be able to reach the "latest URL". > Currently, this gets logged as an ERROR in ambari-server.log. But when > something else goes wrong (completely unrelated), users might think this ERROR > log entry is the cause. But it's not. > > Since w/o internet is a common case, this should not be ERROR to minimize this > chance for confusion. > > > > > 21 Sep 2015 22:12:39,673 INFO [Stack Version Loading Thread] > LatestRepoCallable:74 - Loading latest URL info for stack HDP-2.2 from > http://public-repo-1.hortonworks.com/HDP/hdp_urlinfo.json > 21 Sep 2015 22:12:39,673 ERROR [Stack Version Loading Thread] > LatestRepoCallable:93 - Could not load the URI for stack HDP-2.2 from > http://public-repo-1.hortonworks.com/HDP/hdp_urlinfo.json > (public-repo-1.hortonworks.com) > > > We should just make it INFO and maybe add a bit more info? Like this? > > > > > INFO [Stack Version Loading Thread] LatestRepoCallable:93 - Could not > load the URI for stack HDP-2.2 from > http://public-repo-1.hortonworks.com/HDP/hdp_urlinfo.json > (public-repo-1.hortonworks.com). Using default repository values. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/providers/system.py > d53779c > ambari-common/src/main/python/resource_management/core/resources/system.py > f74e258 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java > cd7d229 > > Diff: https://reviews.apache.org/r/39051/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
