-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39106/#review101843
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
 (line 112)
<https://reviews.apache.org/r/39106/#comment159362>

    The description is not consistent with the display name (HDFS Ranger Plugin 
vs "ranger HDFS plugin").
    Let's make it consistent in name and also capitalization.  
    Do the same for other services.


- Yusaku Sako


On Oct. 7, 2015, 11:09 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39106/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 11:09 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13334
>     https://issues.apache.org/jira/browse/AMBARI-13334
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> adds ranger plugin tab to both HDP-2.2 and HDP-2.3. Also does stack advisor 
> changes to change the properties in respectives services
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  d71b3c2 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  97c2b9f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml
>  9eea80e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
>  e55a5e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml
>  5c6b355 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/metainfo.xml 
> 1d03eac 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
>  74cac2c 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 91d163d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-plugin-properties.xml
>  a3985af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/metainfo.xml 
> 69d908b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme.json
>  31d5cf7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-plugin-properties.xml
>  2817bdd 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 51a514e 
> 
> Diff: https://reviews.apache.org/r/39106/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on HDP-2.3 and HDP-2.2 cluster.
> Verified that python unit tests inside ambari-server package passes:
> ----------------------------------------------------------------------
> Ran 233 tests in 6.934s
> 
> OK
> ----------------------------------------------------------------------
> Total run:807
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to