----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38890/#review101914 -----------------------------------------------------------
ambari-server/src/main/resources/custom_actions/scripts/update_repo.py (line 62) <https://reviews.apache.org/r/38890/#comment159414> Let log here full stacktrace, since it's a big piece of code in try catch we might need that. We might use Logger.logger.exception("ERROR: There was an unexpected error while updating repositories") instead of this print - Andrew Onischuk On Oct. 8, 2015, 2:30 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38890/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 2:30 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Dmytro Sen, > and Sumit Mohanty. > > > Bugs: AMBARI-13274 > https://issues.apache.org/jira/browse/AMBARI-13274 > > > Repository: ambari > > > Description > ------- > > Even though in the AmbariUI (Ambari >> Admin >> Manage Ambari >> versions >> > click on the correct version) you have the correct repos. The > HDP.repo/repoinfo.xml file doesn't get updated in the agent nodes even after > restart of ambari-server and ambari-agents. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 1c110fc > > ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml > 777ced7 > ambari-server/src/main/resources/custom_actions/scripts/update_repo.py > PRE-CREATION > ambari-server/src/test/python/custom_actions/TestUpdateRepo.py PRE-CREATION > > Diff: https://reviews.apache.org/r/38890/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
