----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39183/#review102100 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Oct. 9, 2015, 6:26 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39183/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 6:26 p.m.) > > > Review request for Ambari and Srimanth Gunturi. > > > Bugs: AMBARI-13379 > https://issues.apache.org/jira/browse/AMBARI-13379 > > > Repository: ambari > > > Description > ------- > > *STR:* > # Install a cluster with atleast HDFS > # Open Add Service wizard > # Select Ranger service and partial set of services that is supported by > Ranger. Don't select few services that are supported by Ranger > # Go to Service configuration page -> Ranger service tab -> Ranger plugin > smart config tab > > *Expected Result:* Services that are previously installed or selected to be > install, and supported by Ranger should have toggles for Ranger Plugin > > *Actual Result:* Ranger Plugin for all services (even that are not installed > or selected to be install) that are supported by Ranger are visible > > > Also post installation on Ranger service configuration page, Ranger plugin > should be visible for only installed services > > NOTE: As of Ambari-2.1.3 with HDP-2.3 stack: HDFS, YARN, KAFKA, KNOX, STORM, > HIVE and HBASE are the ranger supported services > > *Fix:* > Added a resource property in config condition which defaults to config in > ambari-web, if not explicitly specified in a config condition. > It can be se to service when the *if* condition of a config needs to check > service state instead of a config value. As of now state attribute has not > been introduced and it's always presumed that service condition is for > service being installed or available int the cluster. In the future when > required we can introduce state attribute in config condition to support > wider use cases > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java > 2d98660 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json > 901512b > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml > 96d6147 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml > 5ed7b22 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml > 4c12322 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json > 540c7f5 > ambari-web/app/mappers/configs/themes_mapper.js e23b691 > ambari-web/app/models/configs/config_condition.js 26cf219 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 5cce947 > ambari-web/app/views/common/configs/widgets/config_widget_view.js 5fa6430 > > Diff: https://reviews.apache.org/r/39183/diff/ > > > Testing > ------- > > Tested the patch to work on a cluster. > Verified that all ambari-web unit test passes successfully with the patch: > 9334 tests complete (11 seconds) > 94 tests pending > > > Thanks, > > Jaimin Jetly > >
