----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39163/#review102476 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Oct. 9, 2015, 9:37 a.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39163/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 9:37 a.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-13281 > https://issues.apache.org/jira/browse/AMBARI-13281 > > > Repository: ambari > > > Description > ------- > > List of things implemented in this patch > 1. Enable visualization icon all the time even if there is no query run. > 2. Show a proper error message if visualization icon is clicked without any > query results. > 3. Default maximum number of rows for which graphs are plotted is 10000. > > > Diffs > ----- > > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/query-tabs.js > a636b29 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/query-tabs.hbs > 6b1f8f5 > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js > 0000691 > > Diff: https://reviews.apache.org/r/39163/diff/ > > > Testing > ------- > > Manually tested. Executed the ui test scripts.(ember test) > > > Thanks, > > Pallav Kulshreshtha > >
