----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39319/#review102642 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java (line 88) <https://reviews.apache.org/r/39319/#comment160386> THANK YOU! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java (lines 574 - 579) <https://reviews.apache.org/r/39319/#comment160389> Change doc to reflect the new NOT_REQUIRED state. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java (lines 580 - 590) <https://reviews.apache.org/r/39319/#comment160391> This method seems to no longer send an event out for other hosts which require the repo; is that on purpose? ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (lines 1202 - 1215) <https://reviews.apache.org/r/39319/#comment160388> Maybe add some information here that the NOT_REQUIRED state shouldn't be returned and that it's used to determine INSTALLED vs INSTALLING? ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (lines 1246 - 1247) <https://reviews.apache.org/r/39319/#comment160387> What's with the caps? - Jonathan Hurley On Oct. 14, 2015, 12:19 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39319/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 12:19 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-13423 > https://issues.apache.org/jira/browse/AMBARI-13423 > > > Repository: ambari > > > Description > ------- > > When distributing bits, and the repo is targeting components for patching, > then only send the command to those hosts. > > NOTES: > - This is on a feature branch, made sure tests were functional > - Added a new repo state, a separate effort is ongoing for the transition > logic > - The branch is NOT YET merged with the trunk changes for EU. Once that > settles, that will be brought in. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java > 9b942e5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 4868ca7 > > ambari-server/src/main/java/org/apache/ambari/server/events/ActionFinalReportReceivedEvent.java > de797f3 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > b0f85b4 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > e3bb320 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 1819ef9 > > Diff: https://reviews.apache.org/r/39319/diff/ > > > Testing > ------- > > Manual testing, automated pending. > > > Thanks, > > Nate Cole > >
