> On Oct. 14, 2015, 5:38 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/files/zkSmoke.sh, > > line 60 > > <https://reviews.apache.org/r/39321/diff/1/?file=1098372#file1098372line60> > > > > Can you make the error message more descriptive?
Thanks for the feedback Alejandro. New patch with the diff have been added. - Juanjo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39321/#review102663 ----------------------------------------------------------- On Oct. 14, 2015, 6:20 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39321/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 6:20 p.m.) > > > Review request for Ambari, Andrew-Duplicate-Accct-Inactiv Konwinski and > Yusaku Sako. > > > Bugs: AMBARI-13415 > https://issues.apache.org/jira/browse/AMBARI-13415 > > > Repository: ambari > > > Description > ------- > > When running zookeeper service check as root user the output file created on > /tmp/zkSmoke.out belongs to root. > If the root installation (server and agent) is converted to non-root user, it > fails when running zookeeper service check because the file output file > (/tmp/zkSmoke.out) already exist and non-root user has not permissions to > overwrite it. > > A new rename method has been added to zkSMoke.sh to add time stamp to the name > > The solution porposed is to add a time stamp to the zkSmoke.out file. So the > new one created by non-root user wont override the root one and the > permission wont be affected anymore. > Also different service checks run as root will create diff .out files which > can be also useful for comparison > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/files/zkSmoke.sh > ea4102d > > Diff: https://reviews.apache.org/r/39321/diff/ > > > Testing > ------- > > Zookeeper service check output file /zkSmoke.out is renamed at script level. > This change is not affecting service check tests for Zookeeper. > > Tested of a fresh root installation. Run ZK service-check. Convert Ambari to > non-root and run ZK service-check again. > Not issues, service check runs succesfully and these are the output files (as > expected): > > cd /tmp: > -rw-r--r-- 1 root root 6868 Oct 13 14:58 zkSmoke1444773488.out > -rw-rw-r-- 1 user user 6868 Oct 13 15:02 zkSmoke1444773766.out > > HadoopQA results: > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/3961//testReport/ > > > Thanks, > > Juanjo Marron > >
