----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39126/#review103128 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Oct. 16, 2015, 9:24 a.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39126/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 9:24 a.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-13343 > https://issues.apache.org/jira/browse/AMBARI-13343 > > > Repository: ambari > > > Description > ------- > > Added support for hive view to work with http HS2. > Added hive.transport.mode,hive.http.port,hive.http.path properties to hive > view.Based on these properties hive view will create http/binary > transport(Connection.java).These will be taken from HS2 configuration. > Added httpcomponents dependency. > > > Diffs > ----- > > contrib/views/hive/pom.xml 81ddfc1 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java > d93df24 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java > d0f9c8b > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpBasicAuthInterceptor.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpKerberosRequestInterceptor.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpRequestInterceptorBase.java > PRE-CREATION > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Utils.java > e0dd438 > contrib/views/hive/src/main/resources/view.xml ce0895b > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java > ba37dc7 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/JobLDAPServiceTest.java > 7be8bc9 > > Diff: https://reviews.apache.org/r/39126/diff/ > > > Testing > ------- > > Manual testing done. > Deployed the patched hive jar in views and set HS2 in http mode.Tested hive > view is working properly. > > > Thanks, > > Gaurav Nagar > >
