----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39458/#review103173 -----------------------------------------------------------
Ship it! Ship It! - Oleksandr Diachenko On Oct. 19, 2015, 10:01 p.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39458/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 10:01 p.m.) > > > Review request for Ambari and Oleksandr Diachenko. > > > Bugs: AMBARI-13479 > https://issues.apache.org/jira/browse/AMBARI-13479 > > > Repository: ambari > > > Description > ------- > > In ambari-web/app/utils/configs/config_property_helper.js, the value of > masterComponentHostsInDB.findProperty('component', > 'RESOURCEMANAGER').hostName is calculated irrespective if Yarn > resourcemanager is configured or not. In cases, where Yarn resourcemanager is > not configured, masterComponentHostsInDB.findProperty('component', > 'RESOURCEMANAGER') will result in undefined and will eventually result in > Uncaught TypeError while trying to get the value of hostName. > > > Diffs > ----- > > ambari-web/app/utils/configs/config_property_helper.js 3cafc9f > > Diff: https://reviews.apache.org/r/39458/diff/ > > > Testing > ------- > > mvn test > ``` > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 1215 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 51.783 s > [INFO] Finished at: 2015-10-19T14:41:54-07:00 > [INFO] Final Memory: 12M/214M > [INFO] > ------------------------------------------------------------------------ > ``` > > > Thanks, > > bhuvnesh chaudhary > >
