[
https://issues.apache.org/jira/browse/AMBARI-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966152#comment-14966152
]
Sumit Mohanty commented on AMBARI-3536:
---------------------------------------
[~odiachenko] take a look at client components in HIVE as well - there are two
clients HCAT and HIVE_CLIENT. ServiceCheck likely only uses HIVE_CLIENT. We
could consider enhancing the meta-info to designate target for service check.
> Refactor to remove ActionMetadata
> ---------------------------------
>
> Key: AMBARI-3536
> URL: https://issues.apache.org/jira/browse/AMBARI-3536
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
> Affects Versions: 1.5.0
> Reporter: Oleksandr Diachenko
> Assignee: Oleksandr Diachenko
> Fix For: 2.2.0
>
> Attachments: AMBARI-3536.patch
>
>
> {{ActionMetaDdata}} has hard-coded mappings of service-to-action.
> * Clients per service are already indicated in the stack
> * One client can be designated as a "service check" (a client should be able
> to NOT be defined as a service check)
> * {{getActions(serviceName)}} is only called two places: one of them uses
> only the first element, the other checks to see if a specific string is
> present in the list. This can be refactored.
> * {{getClient(serviceName)}} is called only one time, and is used in
> {{AmbariManagementControllerImpl.addServiceCheckAction(...)}} to isolate a
> hostName
> * {{getServiceCheckAction(serviceName)}} is called only one time and is used
> to see if any service has a SERVICE_CHECK action set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)