> On Oct. 20, 2015, 8:06 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java, > > line 305 > > <https://reviews.apache.org/r/39418/diff/2/?file=1101436#file1101436line305> > > > > Are we enabling assertions anywhere? Default is false (off), so not > > sure the benefit here. (This was probably a leftover from the ported patch > > too) > > Robert Levas wrote: > This was indeed left over from the ported patch. I left it in becuase I > thought you thought it was important. I am not a big fan of that there. > Should I remove it? If so, we should probably remove it from the trunk as > well. > > Nate Cole wrote: > Agreed. Probably something I had left in there as it didn't show as a > change in my diff :)
Removed the assert in Revision 3. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39418/#review103240 ----------------------------------------------------------- On Oct. 20, 2015, 11:39 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39418/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 11:39 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-13441 > https://issues.apache.org/jira/browse/AMBARI-13441 > > > Repository: ambari > > > Description > ------- > > This is a back-port of AMBARI-12506 to Ambari 2.1.3 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 30da833 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > 1e019b7 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java > fec76ab > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > 22b2ca4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > 20b4658 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d1b5102 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > f04c868 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > c005efc > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java > 670e925 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > 3695faa > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4ffe8da > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8fb6e68 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fb98757 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 098444b > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 8eacfa8 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql a947ce0 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/StageTest.java > c1bd8bc > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 798261b > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > 73b1649 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 069f67d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > a779949 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/ServerActionExecutorTest.java > f9b023f > > ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java > c9d7856 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > 76e96d1 > > Diff: https://reviews.apache.org/r/39418/diff/ > > > Testing > ------- > > Manually tested: > - 1.7.0 -> upgrade to 2.1.3 -> enable kerberos (needed to fix > hdfs-site/dfs.namenode.rpc-address and JCE policy on Ambari Server host) > - 1.7.0 (ambari server host w/o agent) -> upgrade to 2.1.3 -> enable kerberos > (needed to fix hdfs-site/dfs.namenode.rpc-address and JCE policy on Ambari > Server host) > - 2.0.2 -> upgrade to 2.1.3 -> enable kerberos > - 2.0.2 -> enable Kerberos -> upgrade to 2.1.3 -> enable NN HA -> enable RM > HA -> RU to HDP 2.3.2.0 > - 2.1.2 -> upgrade to 2.1.3 -> enable kerberos > - 2.1.2 -> enable Kerberos -> upgrade to 2.1.3 > - 2.1.3 -> enable Kerberos > - 2.1.3 (ambari server host w/o agent) -> enable kerberos > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
