----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39517/#review103416 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Oct. 21, 2015, 5:50 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39517/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 5:50 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jaimin Jetly. > > > Bugs: AMBARI-13504 > https://issues.apache.org/jira/browse/AMBARI-13504 > > > Repository: ambari > > > Description > ------- > > This is to detect deviations in Ranger plugin properties for individual > services from the central plugin config in Ranger service. > > Base property Derived property > stack > ranger-env/ranger-hdfs-plugin-enabled > ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled HDP-2.2 > onwards > ranger-env/ranger-hive-plugin-enabled > ranger-hive-plugin-properties/ranger-hive-plugin-enabled HDP-2.2 > onwards > ranger-env/ranger-hbase-plugin-enabled > ranger-hbase-plugin-properties/ranger-hbase-plugin-enabled HDP-2.2 > onwards > ranger-env/ranger-knox-plugin-enabled > ranger-knox-plugin-properties/ranger-knox-plugin-enabled HDP-2.2 > onwards > ranger-env/ranger-kafka-plugin-enabled > ranger-kafka-plugin-properties/ranger-kafka-plugin-enabled HDP-2.3 > onwards > ranger-env/ranger-yarn-plugin-enabled > ranger-yarn-plugin-properties/ranger-yarn-plugin-enabled HDP-2.3 > onwards > ranger-env/ranger-storm-plugin-enabled > ranger-storm-plugin-properties/ranger-storm-plugin-enabled HDP-2.2 > onwards > > This translates to following behavior on web-ui: > If value of ranger-env/ranger-hdfs-plugin-enabled is false on Ranger smart > config page and user changes the value of > ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled to true on HDFS > service page and saves the configuration then it should show validation error > saying that the value of ranger-env/ranger-hdfs-plugin-enabled and > ranger-hdfs-plugin-properties/ranger-hdfs-plugin-enabled should always be same > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 7fb9884 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 3192ca2 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 2326d34 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 3362c94 > > Diff: https://reviews.apache.org/r/39517/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
