> On Oct. 22, 2015, 2:19 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml, > > line 175 > > <https://reviews.apache.org/r/39549/diff/2/?file=1103235#file1103235line175> > > > > Seems to me that cluster-env is a better place. This is always > > available for all commands. We can then skip all changes to metainfo.xml > > Dmytro Sen wrote: > We can't, these changes to metainfo are required to show restart-required > icon next to the corresponding services to the user on UI if they add this > metrics_vip_host to ams-site. Otherwise we should replace it with > <config-type>cluster-env</config-type> in all metainfo's > > cluster-env is always handled in an other way cause it isn't mapped to > any service. For instance, UI doesn't allow user to change any cluster-env > properties, they're handled as read-only.
In fact that was my intention. These configs should not be changeable by UI and its OK to expect full service stop and start after the change - we will document it. Once you have the implementation for AMS HA this feature can be deprecated. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39549/#review103579 ----------------------------------------------------------- On Oct. 22, 2015, 12:27 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39549/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 12:27 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13521 > https://issues.apache.org/jira/browse/AMBARI-13521 > > > Repository: ambari > > > Description > ------- > > Currently the address of the AMS Collector is automatically picked up from > the host assignment to the component. When AMS is used in the active-passive > configuration then the hostname of the collector should be explicitly > specifiable. That way, it can be configured to have the collector traffic > flow through the VIP. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml > f40da62 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > 76a39a4 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 8b5ec7a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py > 7c68d98 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2 > f0a14b6 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 > 40b18d7 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/metainfo.xml > 5e5e4a7 > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py > a80ea1e > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metainfo.xml > 78aca3d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > f7ff2d5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > b678e51 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/metainfo.xml > dcfe520 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py > dc0c087 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml > fd5e58d > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > df65185 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2 > 460e391 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2 > 060b4fc > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml > 969c2a7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 70c69fe > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py > 093ea38 > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 6642603 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 57365b6 > > Diff: https://reviews.apache.org/r/39549/diff/ > > > Testing > ------- > > Manually tested + all unit tests passed > > ---------------------------------------------------------------------- > Ran 247 tests in 7.988s > > OK > ---------------------------------------------------------------------- > Total run:810 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmytro Sen > >
