> On Oct. 22, 2015, 1:05 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > line 25 > > <https://reviews.apache.org/r/39491/diff/2/?file=1102779#file1102779line25> > > > > Please use pythonic_function_names and variables, lowercase and > > underscores > > > > Also, add some documentation for this function.
While all new code follows pythonic convention, this particular file has camel case convention, so I used the same for consistency. Conversion to pythonic style should be done for all stack_advisor.py files which was not in the scope of this story. The function itself extends the one in parent class, so documentation on function overall purpose belongs there. The logic performed in this particular function is already documented with "# remove HAWQSTANDBY on a single node" which describes what this logic does. I don't believe any additional documentation will be needed. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39491/#review103501 ----------------------------------------------------------- On Oct. 22, 2015, 12:04 a.m., Alexander Denissov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39491/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 12:04 a.m.) > > > Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, > Mahadev Konar, and Oleksandr Diachenko. > > > Bugs: AMBARI-13442 > https://issues.apache.org/jira/browse/AMBARI-13442 > > > Repository: ambari > > > Description > ------- > > Introduced layout recommendations and validations for Apache HAWQ service > master components. > > Test cases use new test json files for input rather than hardcoding data in > the test case directly. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 501517f > ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json > PRE-CREATION > > ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > e0c6d28 > > Diff: https://reviews.apache.org/r/39491/diff/ > > > Testing > ------- > > Added new and ran python unit tests: > ---------------------------------------------------------------------- > Total run:775 > Total errors:0 > Total failures:0 > OK > > > File Attachments > ---------------- > > updated with fix > > https://reviews.apache.org/media/uploaded/files/2015/10/22/b04e7344-e7d7-4577-aa34-d7850f5ef090__AMBARI-13442.patch.1 > > > Thanks, > > Alexander Denissov > >
