> On Oct. 23, 2015, 3:27 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > line 212 > > <https://reviews.apache.org/r/39609/diff/1/?file=1105280#file1105280line212> > > > > Just as an FYI, you may have problems cherry picking this injection > > changes to branch-2.1 - it might still be used there.
Great point - i'll see what my diff thinks. If it bitches I'll revert this particular change. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39609/#review103833 ----------------------------------------------------------- On Oct. 23, 2015, 3:24 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39609/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 3:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-13552 > https://issues.apache.org/jira/browse/AMBARI-13552 > > > Repository: ambari > > > Description > ------- > > The Upgrade/type field is already used as a linked field from the Request > object, so expose the upgrade type (ROLLING/EXPRESS (aka NON_ROLLING)) as > Upgrade/upgrade_type > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 044c707 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > bb78ca2 > > Diff: https://reviews.apache.org/r/39609/diff/ > > > Testing > ------- > > Manual; automated pending > > > Thanks, > > Nate Cole > >
