> On Oct. 23, 2015, 8:21 p.m., Jayush Luniya wrote: > > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py, line 98 > > <https://reviews.apache.org/r/39607/diff/2/?file=1105199#file1105199line98> > > > > Why not support only_if=None instead? There could be other places were > > we might have been using only_if=None that might have been broken too. Just > > that we havent caught them.
I couldn't find what led to this. Having only_if=None seems odd to begin with. I searched the code base and only HDFS was setting only_if=None, so I believe this is fixed. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39607/#review103844 ----------------------------------------------------------- On Oct. 23, 2015, 7 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39607/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 7 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, Nate Cole, and Xi Wang. > > > Bugs: AMBARI-13548 > https://issues.apache.org/jira/browse/AMBARI-13548 > > > Repository: ambari > > > Description > ------- > > NameNode start command is failing in this call, > ``` > # Always run this on non-HA, or active NameNode during HA. > create_hdfs_directories(is_active_namenode_cmd) > ``` > > It appears that the HdfsResource call no longer skips the task when the > only_if condition is set to None. > > > For the NonRolling Upgrade Packs, change the title of the groups, > Rename the high-level and low-level to be this… > - Stop Components for High-Level Services > - Stop Components for Core Services (HDFS, HBase, ZooKeeper and Ranger) > > Rename these others… > - Zookeeper => ZooKeeper > - MR and YARN => YARN and MapReduce2 > - Take Backups =>Perform Backups > - Update Desired Stack Id => Update Target Stack > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/environment.py > 134f164 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > 98b8afd > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > a71c379 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 5aacfa0 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 9997c12 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > e92a413 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py afa404c > > Diff: https://reviews.apache.org/r/39607/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Total run:818 > Total errors:0 > Total failures:0 > > > Thanks, > > Alejandro Fernandez > >
