----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39587/#review103938 -----------------------------------------------------------
Ship it! ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 276) <https://reviews.apache.org/r/39587/#comment162045> I suggest to check for is None or password.strip() == "" - Alejandro Fernandez On Oct. 23, 2015, 12:50 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39587/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 12:50 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, > Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako. > > > Bugs: AMBARI-13538 > https://issues.apache.org/jira/browse/AMBARI-13538 > > > Repository: ambari > > > Description > ------- > > Patch contains changes in Ranger install script to exit, if ' " \ ` are > present in password field for LDAP / AD bind user. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 3900196 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > f41fb4d > > Diff: https://reviews.apache.org/r/39587/diff/ > > > Testing > ------- > > Tested Ranger/ Usersync/ KMS installation (via Ambari) using Mysql, Oracle, > Postgres, MS SQL, SQLAnywhere and Azure DB by using various combinations of > special characters. > > Mentioned password combinations were also tested on Bind Password field for > AD/LDAP Sync/Authentication. > > > ---------------------------------------------------------------------- > Ran 267 tests in 6.516s > > OK > ---------------------------------------------------------------------- > Total run:858 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Gautam Borad > >
