> On Oct. 26, 2015, 7:48 a.m., Gautam Borad wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml, > > line 241 > > <https://reviews.apache.org/r/39627/diff/2/?file=1106530#file1106530line241> > > > > If this propertiy is introduced in 2.2/ranger-env.xml(ie > > common-services), then it should get removed from 2.3/ranger-env.xml
It's UI only property (common property for enabling audit to hdfs on Ranger smart config page). We are also using that property in HDP-2.3 to achieve same functionality > On Oct. 26, 2015, 7:48 a.m., Gautam Borad wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml, > > line 263 > > <https://reviews.apache.org/r/39627/diff/2/?file=1106530#file1106530line263> > > > > If this propertiy is introduced in 2.2/ranger-env.xml(ie > > common-services), then it should get removed from 2.3/ranger-env.xml It's UI only property (common property for HDFS dir location on Ranger smart config page). We are also using that property in HDP-2.3 to achieve same functionality > On Oct. 26, 2015, 7:48 a.m., Gautam Borad wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml, > > line 276 > > <https://reviews.apache.org/r/39627/diff/2/?file=1106530#file1106530line276> > > > > If this propertiy is introduced in 2.2/ranger-env.xml(ie > > common-services), then it should get removed from 2.3/ranger-env.xml It's UI only property (common property for enabling audit to hdfs on Ranger smart config page). We are also using that property in HDP-2.3 to achieve same functionality - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39627/#review103986 ----------------------------------------------------------- On Oct. 26, 2015, 6:49 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39627/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 6:49 a.m.) > > > Review request for Ambari, Gautam Borad, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-13557 > https://issues.apache.org/jira/browse/AMBARI-13557 > > > Repository: ambari > > > Description > ------- > > Add Admin, usersync and Audit tab in Ranger theme for Ranger 0.4.0 (HDP-2.2 > stack) > Make stack advsior changes to set service related ranger properties in > HDP-2.2 stacks automatically > Patch also resolves a bug where JDBC URL value for Oracle database had > missing '/' > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > f530330 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 59b7d9e > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml > 742e971 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > d62f44b > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > 77fdc1a > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 68da87e > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml > 3eb3c0f > > ambari-server/src/main/resources/stacks/HDP/2.2/services/RANGER/themes/theme_version_1.json > 23f1a0b > > ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml > e2ff6fe > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml > 5d7f7ce > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml > 0f1c837 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json > 187942c > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 464f9cc > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > ee21cdb > ambari-server/src/test/python/unitTests.py fe9b60a > ambari-web/app/data/HDP2.2/site_properties.js 9235dfa > ambari-web/app/data/HDP2.3/site_properties.js 9f64912 > > Diff: https://reviews.apache.org/r/39627/diff/ > > > Testing > ------- > > Tested on a live cluster. > Verifeid that ambari-web and python unit tests passes successfully: > > Existing ambari-web unit tests with the patch: > > 10142 tests complete (11 seconds) > 104 tests pending > > > > Python unit tests covering stack advisor changes: > > ---------------------------------------------------------------------- > Ran 236 tests in 6.878s > > OK > ---------------------------------------------------------------------- > Total run:827 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jaimin Jetly > >
