----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39700/#review104212 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java (lines 770 - 774) <https://reviews.apache.org/r/39700/#comment162505> My preference is not to use the transition logic and directly update the entities. For instance, assume one host is still in INSTALLED and never went to UPGRADING because no components on it were ever upgraded. In this scenario, it's safer to directly change the record to CURRENT. And also, update the previously CURRENT record to INSTALLED. - Alejandro Fernandez On Oct. 27, 2015, 9:08 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39700/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 9:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-13591 > https://issues.apache.org/jira/browse/AMBARI-13591 > > > Repository: ambari > > > Description > ------- > > {{ambari-server --set-current}} should have an additional option to set a > version to current. Existing functionality takes the information passed in > and calls the Finalize action. This attempts to go through the framework and > "cleanly" make sure all the versions are correct by applying the same logic > as finalize. > > Add a {{--force}} option to do the db work directly without going through the > finalize action, modeled after what the RU magician does. If work is small > enough, possible backport to 2.1.3. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 2a1431d > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > 8d4c5ee > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java > 2620c8c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java > d5707be > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > ad617af > ambari-server/src/main/python/ambari-server.py 2fae1ee > ambari-server/src/main/python/ambari_server/serverUpgrade.py 7048812 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 1819ef9 > ambari-server/src/test/python/TestServerUpgrade.py 7ef74b2 > > Diff: https://reviews.apache.org/r/39700/diff/ > > > Testing > ------- > > Manual verification. Automated pending. > > > Thanks, > > Nate Cole > >
