----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39704/#review104283 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java (lines 365 - 372) <https://reviews.apache.org/r/39704/#comment162550> Should put it in xml, even if it makes it a little bigger. Part of the point of having it in xml is so that it's easy to see how things get orchestrated without needing to look into code. Some magic is ok, but too much magic and it just gets irritating when trying to make upgrade packs. - Nate Cole On Oct. 27, 2015, 6:47 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39704/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 6:47 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-13590 > https://issues.apache.org/jira/browse/AMBARI-13590 > > > Repository: ambari > > > Description > ------- > > Allow Oozie service to be upgraded/downgraded during Express Upgrade in the > following paths, > HDP 2.1->2.3 > HDP 2.2->2.2.* > HDP 2.2->2.3 > HDP 2.3->2.3.* > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > ddfc36e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py > bb60ec3 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py > 31807f5 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py > 81d8c0c > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > 5e32031 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 5c3fa87 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > c245cc5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > abf142e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 6eca441 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 857cea6 > > Diff: https://reviews.apache.org/r/39704/diff/ > > > Testing > ------- > > Testing during Express Upgrade > > Unit tests passed, > ---------------------------------------------------------------------- > Total run:826 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
