----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39732/#review104361 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json (line 48) <https://reviews.apache.org/r/39732/#comment162623> We can remove all this sections and leave only general_deps (the one at the top). Two reasons for this: 1. Sections from previous stack will be inherited (looked that up in code). 2. It's enough to define "RANGER_USERSYNC-START" dependency in general_deps section. So all other will pick this up. (looked that up it code) Explanation for this: The logic rco_parse has something like this: add("general_opts") if HA: append("namenode_optional_ha") # this includes merging fields with the name ... Merging function is private void addDependency(Role blockedRole, RoleCommand blockedCommand, Role blockerRole, RoleCommand blockerCommand) - Andrew Onischuk On Oct. 28, 2015, 10:08 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39732/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 10:08 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-13616 > https://issues.apache.org/jira/browse/AMBARI-13616 > > > Repository: ambari > > > Description > ------- > > As part AMBARI-13421 the role command order has been changed to ensure the > ranger admin is started before any other services that may use it on the same > host. With this change some of the old role command order dependencies were > incorrectly overridden thus causing HiveSever (and potentially others) to > fail starting when cluster is deployed through UI wizard. > The ranger role command ordering has to be accommodated in such way that it > doesn't break the original dependencies. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json > 3beed16 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java > 6a13ab2 > > Diff: https://reviews.apache.org/r/39732/diff/ > > > Testing > ------- > > Manual testing: > > 1. Tested changes with deploying a 3 node cluster (HDP-2.3: HDFS + Zookeeper) > using the Wizzard and than enabling Namenode HA > 2. Tested the same scenario as #1 but this time with Hive service included as > well > 3. Deploying Ranger using Blueprint > > > Thanks, > > Sebastian Toader > >
