[
https://issues.apache.org/jira/browse/AMBARI-13364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981980#comment-14981980
]
Jayush Luniya commented on AMBARI-13364:
----------------------------------------
[~tctruong]
Thanks for sharing the proposal.
My feedback
# We should take an incremental approach towards this and be very careful not
to introduce regressions.
# Start with cleaning up function names that contain hdp and rename them.
# Then take a simple service and refactor the changes.
# Moving the stack specific paths etc to cluster-env or creating a stack-env is
a good approach.
# Apart from ensuring that clean installs work, we should also verify that
upgrade scenarios work (ambari-server upgrade, ambari-agent upgrade).
# You might want to consider creating a feature branch for this, so that you
can stabilize your changes there and then plan a schedule with the community to
push the changes to trunk.
On a side note:
While we do need to do this clean up, also take a look at
ambari-common/src/main/python/pluggable_stack_definition/GenerateStackDefinition.py
as a stop-gap solution. You can use this module to generate a stack from HDP
stack at build time. This effectively replaces all HDP hardcodings and can be
used to build a custom stack. The config file is a JSON file which specifies a
mapping between HDP stack and your custom stack (ex: HDP 2.3 -> ODP 0.9) and
what replacements need to be run etc. See
ambari-common/src/main/python/pluggable_stack_definition/configs/ODP.json as a
reference.
Usage:
GenerateStackDefinition.py -c <config> -r <resources_folder> -o <output_folder>
> Parameterize stack information used by common services
> -------------------------------------------------------
>
> Key: AMBARI-13364
> URL: https://issues.apache.org/jira/browse/AMBARI-13364
> Project: Ambari
> Issue Type: New Feature
> Components: ambari-server
> Reporter: Tuong Truong
> Assignee: Juanjo Marron
> Attachments: AMBARI-13364 Parameterize stack information used by
> common services.pdf, AMBARI-13364.patch
>
>
> This feature will add a basic framework to remove hardcoded stack information
> out of the common services and use parameter to get access to stack
> information. Currently, the common services hardcoded much information
> specific to Hortonworks' HDP stack including name (HDP), specific versions
> (2.0, 2.1, 2.2), and install location. This feature will propose a way of
> configuration these information and parameterize them into the services for
> reference as require.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
