----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38918/#review105154 -----------------------------------------------------------
Ship it! Ship It! - Srimanth Gunturi On Oct. 1, 2015, 9:20 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38918/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2015, 9:20 a.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-13279 > https://issues.apache.org/jira/browse/AMBARI-13279 > > > Repository: ambari > > > Description > ------- > > Earliar : In case of error the Results tab is empty and Logs tab contains > error and the status shows as completed. But there is no cue that some error > occurred. > After the Patch : if the results is empty the Logs open up and the lines > containing " ERROR " are highlighted. There is a warning sign near the Logs > Heading and near the Completed Status showing that something might be wrong. > > In the Patch : complete UI side changes > Refactoring in pig.js and pigAlert.js controller. > pigScript.js : extracted out function getOrCreate to handle complexity of > getting script from store or create > scriptJob.js : added properties to handle when to show logs and to check if > result is empty. > highlightErrors.js : new component to highlight error lines. > jobs.hbs : added the warning sign. used the hightlight component to show the > ERROR lines > jobs.js : handled collapsing and uncollapsing of Logs > > > Diffs > ----- > > > contrib/views/pig/src/main/resources/ui/pig-web/app/components/highlightErrors.js > PRE-CREATION > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pig.js > 1741a07 > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigAlert.js > 27685f2 > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/pigScripts.js > 2c2318b > > contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptJob.js > 2d8226b > contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js 91b335b > contrib/views/pig/src/main/resources/ui/pig-web/app/styles/style.less > 652cc9b > > contrib/views/pig/src/main/resources/ui/pig-web/app/templates/script/job.hbs > 1584648 > contrib/views/pig/src/main/resources/ui/pig-web/app/views/pig/alert.js > 542e047 > contrib/views/pig/src/main/resources/ui/pig-web/app/views/script/job.js > 6582688 > > Diff: https://reviews.apache.org/r/38918/diff/ > > > Testing > ------- > > Manual testing of UI by generating error case and success case done. > > > Thanks, > > Nitiraj Rathore > >
