----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40100/#review105724 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Nov. 9, 2015, 7:26 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40100/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 7:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-13801 > https://issues.apache.org/jira/browse/AMBARI-13801 > > > Repository: ambari > > > Description > ------- > > During Upgrade Pre-Req Check, when there are hosts in maintenance mode, a > confusing messaging is shown where the title says “All hosts should be > heartbeating” but the warning message says “Following hosts are in > Maintenance Mode”. These checks should be broken into two distinct checks: > one for heartbeating, one for hosts in maintenance mode. > > Currently, we only have 1 check for this. It will produce a {{FAIL}} if there > are hosts not heartbeating and not in MM and will produce an {{WARNING}} if > there are hosts in MM. We can separate these out into two distinct checks. In > which case: > > - The hosts heartbeating check would only report a {{FAIL}} and _not_ a > {{WARNING}} > - The hosts in MM check would only report a {{WARNING}}, never a {{FAIL}} > - The heartbeat check would always be performed before the MM check > > {panel:title=Heartbeating} > Description: All hosts must be communicating with Ambari. Hosts which are not > reachable should be placed in Maintenance Mode. > > Failure Reason: There are hosts which are not communicating with Ambari. > Hosts: c6401.ambari.apache.org > {panel} > > {panel:title=MM Check} > Description: Hosts in maintenance mode will be excluded from the upgrade. > > Warning Reason: There are hosts in maintenance mode which will be excluded > from the upgrade. > Hosts: c6402.ambari.apache.org > {panel} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > 603b279 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java > a6811cb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheck.java > f862d09 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostMaintenanceModeCheckTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java > 847027c > > Diff: https://reviews.apache.org/r/40100/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
