Jonathan Hurley created AMBARI-13816:
----------------------------------------
Summary: Save Cluster State Should Not Be Automatically Skipped
During Upgrade
Key: AMBARI-13816
URL: https://issues.apache.org/jira/browse/AMBARI-13816
Project: Ambari
Issue Type: Bug
Components: ambari-server
Affects Versions: 2.1.3
Reporter: Jonathan Hurley
Assignee: Jonathan Hurley
Priority: Blocker
Fix For: 2.1.3
The easiest solution here is to make a new group for the finalize action and
then make that group not skippable. However, that might not be a desirable
"feature" This step exists in a skippable group, which means it can be
automatically skipped
{code}
<execute-stage title="Save Cluster State" service="" component="">
<task xsi:type="server_action"
class="org.apache.ambari.server.serveraction.upgrades.FinalizeUpgradeAction"/>
</execute-stage>
{code}
But this task should never be auto skipped - I'd argue that it should never be
skipped at all. Either abort the upgrade if this fails or downgrade or finalize
later. However, it seems that the overall approach is to allow most upgrade
items to be skipped.
If we say that, "No, finalize _must_ also be skippable because we always want
them to 'finish' the upgrade", then I think we'd need to do some work here to
introduce the notion of a non-auto-skip property in the XML.
{code}
<group xsi:type="cluster" name="POST_CLUSTER" title="Finalize
{{direction.text.proper}}">
<skippable>true</skippable>
<supports-auto-skip-failure>false</supports-auto-skip-failure>
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
