> On Nov. 10, 2015, 6:15 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > line 366 > > <https://reviews.apache.org/r/40139/diff/1/?file=1121826#file1121826line366> > > > > If we remove this line, and any stage has failures, the whole request > > will be still marked as FAILED. > > But if we consider skipped failures as nothing serious, then probably > > removal of this line should do the trick
On the other hand, if any stage has non-skippable failures, then it's fatal. So probably I would not map SKIPPED_FAILED to anything and will just remove this line. - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40139/#review105887 ----------------------------------------------------------- On Nov. 10, 2015, 6:12 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40139/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 6:12 p.m.) > > > Review request for Ambari, Nate Cole and Yusaku Sako. > > > Repository: ambari > > > Description > ------- > > Uploaded a patch for discussion > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > f87c32c > > Diff: https://reviews.apache.org/r/40139/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
