> On Ноя. 10, 2015, 5:08 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml, > > line 40 > > <https://reviews.apache.org/r/40141/diff/1/?file=1121872#file1121872line40> > > > > Could we have remove the content property from HDP-2.3 if its the same > > as the one in 2.2?
https://reviews.apache.org/r/40141/ [19:24:44] Ivan Kozlov(CV Ambari Server team): They are different. hive-env for 2.3 has following code, which is absent in hive-env 2.2: {% if sqla_db_used or lib_dir_available %} export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:{{jdbc_libs_dir}}" export JAVA_LIBRARY_PATH="$JAVA_LIBRARY_PATH:{{jdbc_libs_dir}}" {% endif %} - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40141/#review105897 ----------------------------------------------------------- On Ноя. 10, 2015, 4:23 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40141/ > ----------------------------------------------------------- > > (Updated Ноя. 10, 2015, 4:23 п.п.) > > > Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi. > > > Bugs: AMBARI-13817 > https://issues.apache.org/jira/browse/AMBARI-13817 > > > Repository: ambari > > > Description > ------- > > It could be as simple as making sure that > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml > has the same changes as in the 2.2. version > (ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml). > Specifically the missing parts are: > export SERVICE=$SERVICE > if [ "$SERVICE" = "metastore" ]; then > export HADOOP_HEAPSIZE="{{hive_metastore_heapsize}}" > else > export HADOOP_HEAPSIZE="{{hive_heapsize}}" > fi > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java > 3211b36 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 447993d > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml > c331802 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-env.xml > 30141c6 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java > 521dede > > Diff: https://reviews.apache.org/r/40141/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
