----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40163/#review106054 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Nov. 11, 2015, 1:07 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40163/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 1:07 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and > Richard Zang. > > > Bugs: AMBARI-13814 > https://issues.apache.org/jira/browse/AMBARI-13814 > > > Repository: ambari > > > Description > ------- > > Add (descriptive) label to permission resource and database schema to avoid > having to hardcode a descriptive name for a permission. For example: > > > Permission Name | Permission Label > ----------------------|------------------------ > VIEW.USER | View User > CLUSTER.USER | Cluster User > SERVICE.OPERATOR | Service Operator > SERVICE.ADMINISTRATOR | Service Administrator > CLUSTER.OPERATOR | Cluster Operator > CLUSTER.ADMINISTRATOR | Cluster Administrator > > This descriptive label can be used in user interfaces so that a descriptive > (or friendly) name does not have to be hardcoded. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java > 287c2e6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java > db73774 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java > 804d97b > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c00e46f > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3cac618 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 2bcfb9a > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 56dff9b > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1cc83ed > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 4b4b0d4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java > d1907b7 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java > ad704a5 > > Diff: https://reviews.apache.org/r/40163/diff/ > > > Testing > ------- > > Manually tested API call on both fresh and upgraded installation > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
