> On Nov. 11, 2015, 4:03 p.m., Andrew Onischuk wrote: > > Di, also one more question. As far as I know, new repositories are > > automatically added to cache on suse/rhel when first yum/zypper install is > > triggered. Do we target something else here?
hello Andrew, Thanks for the explanation. I will just use this one for all your comments 1. Repo vs package install in the basic case: I guess one way to deal with this is to create repo on each agent before installing packages. This require some serious changes to the way agent install packages, I suppose. I get it that trying to create the repo file per package install can make sure the repo file content is always up to date. 2. Locks: it's not being handled right now. 3. Purpose of the jira: This is a very special case where the cache contains out of date info of HDP which may cause the install pacakge steps to fail when user tries to run rolling upgrade or do a fresh install. This may happen for a cluster previous installed with HDP (when user does a floppy job on clean up the cluster or clean up the repo cache properly). The logic here is try to do some cache cleaning when Ambari creates the repo file on each Agent node. Just as you said, new repo logic in SLES/RHEL is perfectly fine, for a cluster that has never been installed with HDP before or when user properly cleans up repo cache. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40080/#review106074 ----------------------------------------------------------- On Nov. 10, 2015, 9:02 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40080/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 9:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush > Luniya, and Sid Wagle. > > > Bugs: AMBARI-13748 > https://issues.apache.org/jira/browse/AMBARI-13748 > > > Repository: ambari > > > Description > ------- > > Need a way for Ambari to trigger a repository clean (yum clean expire-cache > on rhel, for example) when updating repository files during an Ambari update > as well as fresh installation of a cluster. > > Currently, this must be done occasionally through a manual step, and if not > done will lead to problems during install. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/providers/repository.py > 11002cc > > ambari-common/src/main/python/resource_management/libraries/resources/repository.py > 2484d67 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 1dfaa54 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 05751fa > ambari-server/src/test/python/custom_actions/TestInstallPackages.py 83b6bb5 > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > f9d69a8 > > Diff: https://reviews.apache.org/r/40080/diff/ > > > Testing > ------- > > New unit test. Patch cluster with the changes and run fresh install and > rolling upgrade to verify the repo clean up logic was run. > > > Thanks, > > Di Li > >
