----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40098/#review106143 -----------------------------------------------------------
Nicely done. ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 241) <https://reviews.apache.org/r/40098/#comment164844> Can you add a comment as to why this was needed during EU. ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 245) <https://reviews.apache.org/r/40098/#comment164841> I believe "map" is a reserved word, we should use something else ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 249) <https://reviews.apache.org/r/40098/#comment164842> To help read this, perhaps we should add the package name and indent the message with 2 spaces. ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 254) <https://reviews.apache.org/r/40098/#comment164843> No need for single quotes ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (line 28) <https://reviews.apache.org/r/40098/#comment164845> Let's use explicit imports intead of * ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py (line 57) <https://reviews.apache.org/r/40098/#comment164846> Add some doc as to why we had to do this, including the oozie-client on this host. ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 688) <https://reviews.apache.org/r/40098/#comment164847> Add some comment as to why we had to call configure before calling oozie_server_upgrade.upgrade_oozie_database_and_sharelib() - Alejandro Fernandez On Nov. 11, 2015, 1:48 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40098/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 1:48 a.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-13824 > https://issues.apache.org/jira/browse/AMBARI-13824 > > > Repository: ambari > > > Description > ------- > > Stop-and-Start Upgrade: Fix for Oozie Express upgrade issues from HDP 2.1 to > 2.3 > > > Problem : Unable to start Ozzie server while on upgrade from HDP 2.1 -> 2.3. > > Reason : As 2.3 has symlinks instead of directory structure for > "/etc/oozie/conf" and "usr/hdp/current/oozie-*/conf". > * -> "server" or "client" > > The symlinks are not properly set for Ozzie Server and client after the > upgrade. > > Resolution : Added a new class and comamnd "CONFIGURE_FUNCTION" to get the > sym links working. > > After the upgrade, the symlinks are : > > ================================================ > /etc/oozie/conf -> /etc/oozie/2.3.4.0-3204/0 > /usr/hdp/current/oozie-server/conf -> /etc/oozie/2.3.4.0-3204/0 > ================================================ > > > P.S. The changes are generic in "conf_select" for setting the sym links. > Thus, other services also should be having their > symlinks working in 2.1->2.3 upgrade path. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 620f021 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 9ba5a22 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 915e431 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureFunction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > 4ef14a6 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java > 2ea3671 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > f443e53 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py > f35df93 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > fd28ce8 > > Diff: https://reviews.apache.org/r/40098/diff/ > > > Testing > ------- > > - Upgrade from HDP 2.1 -> 2.3 successful. Oozie Servier and UI working fine. > - > - Unit test cases : run. Successful. > ---------------------------------------------------------------------- > Ran 249 tests in 6.416s > > OK > ---------------------------------------------------------------------- > Total run:828 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Swapan Shridhar > >
