> On Nov. 12, 2015, 12:18 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 324 > > <https://reviews.apache.org/r/40202/diff/1/?file=1123678#file1123678line324> > > > > Why do we need the if ... else ... in this line. Same for the next set > > of changes.
To avoid string concatenation if serverProperties['authentication.ldap.primaryUrl'] is None/null. I was not sure how python code behaves in such situation. - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40202/#review106179 ----------------------------------------------------------- On Nov. 11, 2015, 11:30 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40202/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2015, 11:30 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-13847 > https://issues.apache.org/jira/browse/AMBARI-13847 > > > Repository: ambari > > > Description > ------- > > When configuring LDAP/AD for usersync in new Ranger smart config, Ambari > should construct the LDAP/AD url with prefix "ldap://";. For example, the url > should like "ldap://localhost:389"; > > When ambari is configurd with LDAP, ranger.usersync.ldap.url value should be > set to authentication.ldap.primaryUrl with ldap:// as the prefix if not using > ssl and should be prefixed with ldaps:// if using ssl. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 7181122 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 7d2b625 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > f29d147 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > a1114fc > > Diff: https://reviews.apache.org/r/40202/diff/ > > > Testing > ------- > > Verified that the patch works manually on a cluster. > Verified that ambari-server (inclusive of stack advisor tests) unit tests > passes with the patch > ---------------------------------------------------------------------- > Ran 238 tests in 6.900s > OK > ---------------------------------------------------------------------- > Total run:832 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jaimin Jetly > >
