----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40092/#review106244 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Nov. 12, 2015, 2:14 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40092/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 2:14 p.m.) > > > Review request for Ambari, Jonathan Hurley, Robert Nettleton, Richard Zang, > and Yusaku Sako. > > > Bugs: AMBARI-13791 > https://issues.apache.org/jira/browse/AMBARI-13791 > > > Repository: ambari > > > Description > ------- > > Rename existing permissions to prepare for the new role base access control > naming conventions: > > > * View User: `VIEW.USE` --> `VIEW.USER` > * Cluster User: `CLUSTER.READ` --> `CLUSTER.USER` > * Cluster Administrator: `CLUSTER.OPERATE` --> `CLUSTER.ADMINISTRATOR` > * Administrator: `AMBARI.ADMIN` --> `AMBARI.ADMINISTRATOR` > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > d9f5eb5 > ambari-server/docs/api/v1/permission-get.md 0781fbd > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 8dd7a04 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProvider.java > c9e2a83 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java > 2c016e4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java > 5fc20fb > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PermissionDAO.java > bf6ec3a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java > 650b0db > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > 46b751d > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/User.java > ab48ddd > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 29b9ec3 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java > 4494697 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > c9ffee0 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 9ea9581 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java > 30cb1ca > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 1cf4323 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fb2f568 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 162ef33 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql fe58235 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 7e145c4 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0080e46 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 6bfe344 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > a6536c7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java > 148c139 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java > 5737b7c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java > a84cc3f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java > ed8aed0 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > 251692f > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java > 6858d8d > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java > d3eb071 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java > 44ad1a6 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > f9dadcd > ambari-views/docs/index.md 18f1fb3 > ambari-web/app/assets/data/users/privileges.json a461206 > ambari-web/app/assets/data/users/privileges_admin.json a461206 > ambari-web/app/assets/data/users/user_admin.json 72cd945 > ambari-web/app/mappers/users_mapper.js 255de7b > ambari-web/app/models/user.js c7ca9fe > ambari-web/app/router.js d3343c8 > ambari-web/test/mappers/users_mapper_test.js 767a002 > ambari-web/test/router_test.js cbdf4ea > > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java > 2769931 > > Diff: https://reviews.apache.org/r/40092/diff/ > > > Testing > ------- > > Manually tested fresh cluster and upgraded cluster. > > # Jenkins test results: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:43 min > [INFO] Finished at: 2015-11-12T11:03:20+00:00 > [INFO] Final Memory: 40M/363M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
