----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40190/#review106252 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java <https://reviews.apache.org/r/40190/#comment165013> I am not sure if this change is needed. For example, remove is actually correct. In fact we might as well remove the other ldap related property. As far as adding properties are concerned, what happens if the property is already there with some value. Do we overwrite it? ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml (line 1747) <https://reviews.apache.org/r/40190/#comment165014> Is the DONT_ADD_ON_UPGRADE a directive for Stack upgrade or Ambari upgrade? - Sumit Mohanty On Nov. 12, 2015, 2:51 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40190/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 2:51 p.m.) > > > Review request for Ambari, Dmytro Sen and Sumit Mohanty. > > > Bugs: AMBARI-13837 > https://issues.apache.org/jira/browse/AMBARI-13837 > > > Repository: ambari > > > Description > ------- > > HS2 supports LDAP authentication. LDAP could be either Active Directory (AD) > or others. For non-AD LDAP, HS2 needs hive.server2.authentication.ldap.url > and hive.server2.authentication.ldap.baseDN to be set. For AD LDAP, HS2 needs > hive.server2.authentication.ldap.url and > hive.server2.authentication.ldap.Domain to be set. However, when using > Ambari, when we set hive.server2.authentication to LDAP, it always requires > hive.server2.authentication.ldap.baseDN to be set. This prevents users from > specifying the AD LDAP configs. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > ac5df7c > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > f986800 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 5ea3115 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c7e8ebd > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 6b9dcd5 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > a1114fc > > Diff: https://reviews.apache.org/r/40190/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
