> On Ноя. 12, 2015, 6:52 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py,
> > line 189
> > <https://reviews.apache.org/r/40221/diff/2/?file=1123966#file1123966line189>
> >
> > Thsi is good but if FS != HDFS we still need to try and create the
> > hbase.rootdir on local FS.
We do this in elase branch
else:
local_root_dir = params.hbase_root_dir
#cut protocol name
if local_root_dir.startswith("file://"):
local_root_dir = local_root_dir[7:]
#otherwise assume dir name is provided as is
Directory(local_root_dir,
owner = params.hbase_user,
cd_access="a",
recursive = True
)
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40221/#review106296
-----------------------------------------------------------
On Ноя. 12, 2015, 9:50 д.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40221/
> -----------------------------------------------------------
>
> (Updated Ноя. 12, 2015, 9:50 д.п.)
>
>
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
>
>
> Bugs: AMBARI-13851
> https://issues.apache.org/jira/browse/AMBARI-13851
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMS scripts should not assume that hdfs is the protocol.
> is_hbase_distributed = hbase_root_dir.startswith('hdfs://')
>
> or
>
> is_hbase_distributed =
> security_params['hbase-site']['hbase.rootdir'].startswith('hdfs://')
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
> 50e363c
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
> 9e6f2fa
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
> 00e4123
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
> 1c6a49f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
> 7181122
>
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
> b04e1d5
>
> Diff: https://reviews.apache.org/r/40221/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 249 tests in 8.115s
>
> OK
> ----------------------------------------------------------------------
> Total run:831
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
