-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 10:42 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-13798
https://issues.apache.org/jira/browse/AMBARI-13798
Repository: ambari
Description
-------
The AMS result set size property was recently changed through AMBARI-13411.
This bug addresses the corresponding change to the upgrade path.
Also change log statements with respect to result limit exceeded failures to
make sure they convey what the limit vs requested size was. This log statements
must be available on ambari-server.log as well.
To make sure that ambari-server prints out the error, I had needed to change
the way we read from the StreamProvider and read the error stream from the
HttpUrlConnection. Specifically, the StreamProvider interface was changed to
URLStreamProvider in all Metrics Property provider classes and tests.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
92d59e2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
2ef0a8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
8b15569
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java
ad35444
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java
fb74fab
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java
54857cc
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java
9b23686
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java
e531dff
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java
5508cbe
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java
41a500f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java
d2dbb11
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java
cc0219c
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java
0e71049
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java
85e016f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
2af7452
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
8b60c50
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
ca20e54
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
beffa9e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java
415b97b
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java
a7b7553
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java
770dfb6
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
ce865cf
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java
99a2102
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
a03dfc7
Diff: https://reviews.apache.org/r/40110/diff/
Testing
-------
mvn clean test on ambari-metrics.
Manual testing done.
Added unit test to cover this case.
Thanks,
Aravindan Vijayan
