> On Nov. 13, 2015, 6:48 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 975 > > <https://reviews.apache.org/r/40303/diff/1/?file=1125173#file1125173line975> > > > > Is there explicit conversion to byts in the advisor code ? We should be > > resilient to memory speicified in MB, KB of GB.
Yes. In this "Unused memory in collector host" case, we calculate memory remaining on HOST in Bytes. Hence, all relevant recommendations are computed in Bytes and displayed in MB. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40303/#review106479 ----------------------------------------------------------- On Nov. 13, 2015, 6:10 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40303/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 6:10 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Srimanth Gunturi, and > Sid Wagle. > > > Bugs: AMBARI-13869 > https://issues.apache.org/jira/browse/AMBARI-13869 > > > Repository: ambari > > > Description > ------- > > Problem > AMS validation asks to set hbase_master_xmn_size to an unreasonable value of > 4123168640 MB > > Bug > hbase_master_xmn_size recommended value returned in Bytes. > > Fix > Change to MB. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 878b2cd > > Diff: https://reviews.apache.org/r/40303/diff/ > > > Testing > ------- > > Tested against a big cluster to trigger the recommendation message. > > > Thanks, > > Aravindan Vijayan > >
