-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40446/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-13951
https://issues.apache.org/jira/browse/AMBARI-13951
Repository: ambari
Description
-------
If a property in stack definition has property type which is unknown to Ambari
(know property types are listed in PropertyInfo.PropertType) Jaxb will
deserialize this into null reference. This null reference will cause later
service add operations to fail.
To overcome this we just simply skip unknown property types as property types
are not mandatory for the properties.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyRequestDAO.java
65cd59f
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java
a3979c1
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
24c7bce
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/TopologyRequestDAOTest.java
f5ece39
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
2d9d779
Diff: https://reviews.apache.org/r/40446/diff/
Testing
-------
Manual testing:
- Removed "TEXT" property type form PropertyInfo.PropertType enum (this way
making "TEXT" unkown to Ambari)
- Deployed a cluster with 3 nodes
- Added Ranger service to the cluster as Ranger service has properties with
property type "TEXT"
- Verified that Ranger service installed successfully.
Unit tests: currently in progress
Thanks,
Sebastian Toader
