----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40452/#review107085 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Nov. 18, 2015, 8:42 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40452/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 8:42 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-13934 > https://issues.apache.org/jira/browse/AMBARI-13934 > > > Repository: ambari > > > Description > ------- > > When you delete a host, it will delete all associated host_role_commands. > During upgrade, if a host is deleted, then it is possible to have a Stage > within the Upgrade request to have no tasks. Verify that it does not affect > the upgrade operations. > > Possible issues: > * A stage with no tasks should be declared as COMPLETED if not then it may > result in the failure of the request > * Some host_role_command (tasks) may be read once and then cached. Such > cache, if they exist need to be refreshed > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 32e8754 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 2524df8 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 7fcdac9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java > cf9d952 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 911e3cd > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java > d479bfe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > 9b63358 > > Diff: https://reviews.apache.org/r/40452/diff/ > > > Testing > ------- > > Manual testing complete. > Unit testing in progress. > > > Thanks, > > Sid Wagle > >
