----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40484/#review107191 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Nov. 19, 2015, 9:53 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40484/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 9:53 a.m.) > > > Review request for Ambari, Jonathan Hurley and Sumit Mohanty. > > > Bugs: AMBARI-7591 > https://issues.apache.org/jira/browse/AMBARI-7591 > > > Repository: ambari > > > Description > ------- > > The python script invoked behind the "ambari-server status" command does not > return as system exit code the status of ambari-server. Similarly to > "abari-agent status" it should return 0 if ambari-server is running and 3 if > the server is down. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py a0f12e0 > ambari-server/src/test/python/TestAmbariServer.py e2ed2df > > Diff: https://reviews.apache.org/r/40484/diff/ > > > Testing > ------- > > Unit tests results: > Total run:801 > Total errors:0 > Total failures:0 > OK > > Manual testing: > # service ambari-server stop > Using python /usr/bin/python2.6 > Stopping ambari-server > Ambari Server stopped > # service ambari-server status; echo RC=$? > Using python /usr/bin/python2.6 > Ambari-server status > Ambari Server not running. Stale PID File at: > /var/run/ambari-server/ambari-server.pid > RC=3 > > # service ambari-server start > Using python /usr/bin/python2.6 > Starting ambari-server > Ambari Server running with administrator privileges. > Organizing resource files at /var/lib/ambari-server/resources... > Server PID at: /var/run/ambari-server/ambari-server.pid > Server out at: /var/log/ambari-server/ambari-server.out > Server log at: /var/log/ambari-server/ambari-server.log > Waiting for server start.................... > Ambari Server 'start' completed successfully. > # service ambari-server status; echo RC=$? > Using python /usr/bin/python2.6 > Ambari-server status > Ambari Server running > Found Ambari Server PID: 18375 at: /var/run/ambari-server/ambari-server.pid > RC=0 > > > Thanks, > > Sebastian Toader > >
