> On Nov. 18, 2015, 2:10 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/FileCache.py, lines 42-43 > > <https://reviews.apache.org/r/40448/diff/2/?file=1131394#file1131394line42> > > > > I'm not so sure that these belong in the file cache - they are > > directories that contain information pushed to the agents, not data that > > the agents request. > > Dmytro Sen wrote: > It's convenient to have all the agent tmp directory paths defined in the > same place, but I can revert it if you insist.
Oh, OK - if you're only putting them here to manage them, then I'm fine with that. I didn't want them included in any caching. > On Nov. 18, 2015, 2:10 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py, line 840 > > <https://reviews.apache.org/r/40448/diff/2/?file=1131395#file1131395line840> > > > > Always use the temp directory configured in the agent, not hard coded > > to /tmp. > > Dmytro Sen wrote: > def main(argv=None): > cmd_mgr = RecoveryManager('/tmp') > pass > > > That's main method and it is't called by the agent. It's called only > during deployment, agent configuration might not exist. Thanks for explaining. In such cases, should we not use `tempfile.gettempdir()` instead then? > On Nov. 18, 2015, 2:10 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py, line 82 > > <https://reviews.apache.org/r/40448/diff/2/?file=1131396#file1131396line82> > > > > Should `warned_threshold_reached` be a WARNING here? Or is it truly > > CRITICAL? > > Dmytro Sen wrote: > warned_threshold_reached means that RecoveryManager won't make any more > attempts to recover component's state. That's requires close attention from > user, when maximum recovery attempts count reached Sounds good - was just making sure it wasn't a mistake. > On Nov. 18, 2015, 2:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/RecoverySource.java, > > lines 28-30 > > <https://reviews.apache.org/r/40448/diff/2/?file=1131404#file1131404line28> > > > > No need for the empty constructor. > > Dmytro Sen wrote: > I've added it intentionally as a best practice. I won't nitpick you to death :) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40448/#review107067 ----------------------------------------------------------- On Nov. 19, 2015, 10:26 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40448/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 10:26 a.m.) > > > Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-13954 > https://issues.apache.org/jira/browse/AMBARI-13954 > > > Repository: ambari > > > Description > ------- > > - In 2.1.3 we have the watch dog script that will shutdown the API if HBase > is unresponsive for sometime. > - We also have the ability to auto-start per service / component > - The two should work in conjunction for AMS > - User needs to be alerted if Restarts are too frequent > > Alternative approach is for watch to act as a monitor and be responsible for > restarting HBase. > This should still be a alert hook but in that case the alert can be > customized for AMS only. > > To turn on AMS auto-start append ambari.properties with > > recovery.type=AUTO_START > recovery.enabled_components=METRICS_COLLECTOR > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py d3aab87 > ambari-agent/src/main/python/ambari_agent/Controller.py 520d78d > ambari-agent/src/main/python/ambari_agent/FileCache.py 4869e51 > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py cab81f5 > ambari-agent/src/main/python/ambari_agent/alerts/recovery_alert.py > PRE-CREATION > ambari-agent/src/test/python/ambari_agent/TestActionQueue.py df8278b > ambari-agent/src/test/python/ambari_agent/TestAlertSchedulerHandler.py > a08e4bc > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 1e6da64 > ambari-agent/src/test/python/ambari_agent/TestHeartbeat.py 1f3609d > ambari-agent/src/test/python/ambari_agent/TestRecoveryManager.py e6115e3 > ambari-server/conf/unix/ambari.properties 7f0a464 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java > 4bc25f8 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/RecoverySource.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/SourceType.java > 6c1aa9a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json > 319427d > > Diff: https://reviews.apache.org/r/40448/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
