----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40003/#review107284 -----------------------------------------------------------
Ship it! Ship It! - Xi Wang On Nov. 19, 2015, 4:39 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40003/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 4:39 p.m.) > > > Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-13756 > https://issues.apache.org/jira/browse/AMBARI-13756 > > > Repository: ambari > > > Description > ------- > > This is a FE implementation that creates a switchable "Role" section for > admin view so that user can switch between "block" and "list". This UI will > not be visible until the entire project is done. > > > Diffs > ----- > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 44b957f > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > 6aae599 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js > 2496717 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js f34d931 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > fdfb8e2 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js > c87f9d2 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css ff963ee > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/manageAccess.html > d5dcfa2 > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html > PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html > f11ef9e > ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html > 471d899 > ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html > 36efe6f > > Diff: https://reviews.apache.org/r/40003/diff/ > > > Testing > ------- > > Manually tested on live cluster. > All unit tests passed. > INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/ > INFO [launcher]: Starting browser PhantomJS > INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket cHgn_uh6bsd462mEhdYK > with id 5568272 > PhantomJS 1.9.7 (Mac OS X): Executed 13 of 13 SUCCESS (0.012 secs / 0.102 > secs) > > > Thanks, > > Richard Zang > >
