----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40542/#review107368 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Ноя. 20, 2015, 2:03 п.п., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40542/ > ----------------------------------------------------------- > > (Updated Ноя. 20, 2015, 2:03 п.п.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro > Sen. > > > Bugs: AMBARI-13994 > https://issues.apache.org/jira/browse/AMBARI-13994 > > > Repository: ambari > > > Description > ------- > > We need to relax the check and drop -e 'Error' at the end. The reasoning is > as follows: > Longer term, Hive should provide better ways for Ambari to do health checks. > Per Hive committers, some work is going on to expose hiveserver2 metrics that > will help with that. In fact, this is just one of the problems of this way of > doing health checks. If any of the authentication modes in hive that require > passwords is enabled, then connection attempts by this user would still fail. > The ambari-qa user being used to perform health checks may not be present in > the ID store. So in long term, ambari should move away from using ambari-qa > user and rely on HS2 metrics for health check. > Possible fix for user: > we should check if user anonymous is available and belongs to > proxyuser.groups group. Beside this, user hive should be in proxyuser.group > too. In that case everything will work fine. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/hive_check.py > 554b1dc > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 90354b3 > > Diff: https://reviews.apache.org/r/40542/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
