----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40328/#review107544 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Nov. 19, 2015, 2:08 p.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40328/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 2:08 p.m.) > > > Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and > Yusaku Sako. > > > Bugs: AMBARI-13879 > https://issues.apache.org/jira/browse/AMBARI-13879 > > > Repository: ambari > > > Description > ------- > > - Remove the code which was obeserving query editor text area, there is no > need to have that observer. > - checking if the query is of "EXPLAIN" type, then send it to explain handler. > - Added relevant unit test cases for explain and non explain type query > > > Diffs > ----- > > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/query-editor.js > f119fc8 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 735d2c5 > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/components/query-editor-test.js > e70b5ee > > contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js > d66c899 > > Diff: https://reviews.apache.org/r/40328/diff/ > > > Testing > ------- > > mvn clean install > > Here are build logs. > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.344 sec > Running org.apache.ambari.view.hive.client.ConnectionTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.225 sec > Running org.apache.ambari.view.hive.PropertyValidatorTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec > Running org.apache.ambari.view.hive.resources.files.FileServiceTest > Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.798 sec > Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest > Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec > Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.108 sec > Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.622 sec > Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.638 sec > Running org.apache.ambari.view.hive.resources.jobs.LogParserTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 sec > Running > org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.443 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest > Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.099 sec > Running > org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.13 sec > Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 sec > Running org.apache.ambari.view.hive.resources.upload.DataParserTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec > > Results : > > Tests run: 55, Failures: 0, Errors: 0, Skipped: 0 > > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default) @ hive --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: .git/ > [INFO] Exclude: **/.gitignore > [INFO] Exclude: **/.gitattributes > [INFO] Exclude: .idea/ > [INFO] Exclude: pass.txt > [INFO] Exclude: .DS_Store > [INFO] Exclude: .iml/ > [INFO] Exclude: .classpath > [INFO] Exclude: .project > [INFO] Exclude: .settings > [INFO] Exclude: **/target/** > [INFO] Exclude: **/.gitkeep > [INFO] Exclude: **/.bowerrc > [INFO] Exclude: **/.editorconfig > [INFO] Exclude: **/.jshintrc > [INFO] Exclude: **/.tmp/** > [INFO] Exclude: **/tmp/** > [INFO] Exclude: **/*.json > [INFO] Exclude: **/*.svg > [INFO] Exclude: **/vendor/** > [INFO] Exclude: **/bin > [INFO] Exclude: **/node_modules/** > [INFO] Exclude: **/vendor/** > [INFO] Exclude: **/public/** > [INFO] Exclude: **/dist/** > [INFO] Exclude: **/bower_components/** > [INFO] Exclude: **/bower/** > [INFO] Exclude: **/node/** > [INFO] Exclude: **/runner.js > [INFO] Exclude: **/assets/javascripts/** > [INFO] Exclude: **/assets/stylesheets/** > [INFO] Exclude: **/assets/static/javascripts/** > [INFO] Exclude: **/assets/static/stylesheets/** > [INFO] Exclude: storm/src/main/resources/** > [INFO] 337 resources included (use -debug for more details) > Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > Compiler warnings: > WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' > Warning: org.apache.xerces.parsers.SAXParser: Feature > 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 336 licence. > [INFO] > [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive --- > [INFO] Building jar: > /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar > [INFO] > [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive --- > [INFO] Reading assembly descriptor: > /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml > [INFO] > [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive --- > [INFO] Installing > /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar > to > /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.jar > [INFO] Installing > /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/pom.xml > to > /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.pom > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33.150s > [INFO] Finished at: Sun Nov 15 16:40:02 IST 2015 > [INFO] Final Memory: 38M/821M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Pallav Kulshreshtha > >
