[
https://issues.apache.org/jira/browse/AMBARI-14046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025173#comment-15025173
]
Hudson commented on AMBARI-14046:
---------------------------------
FAILURE: Integrated in Ambari-branch-2.1 #931 (See
[https://builds.apache.org/job/Ambari-branch-2.1/931/])
AMBARI-14046. Refactor code that breaks transaction chaining. (mpapyrkovskyy:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=44001de7ff90dece275688a99f41745b22c2fc7b])
*
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/AmbariServer.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/RequestExecutionImpl.java
* ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/RequestExecutionTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
*
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
*
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
*
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
* ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
*
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
*
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
> Refactor code that breaks transaction chaining
> ----------------------------------------------
>
> Key: AMBARI-14046
> URL: https://issues.apache.org/jira/browse/AMBARI-14046
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.0.0
> Reporter: Myroslav Papirkovskyy
> Assignee: Myroslav Papirkovskyy
> Priority: Critical
> Fix For: 2.1.3
>
>
> Pattern issue:
> {code}
> @Transactional
> - private void unmapHostClusterEntities(String hostName, long clusterId) {
> + void unmapHostClusterEntities(String hostName, long clusterId) {
> HostEntity hostEntity = hostDAO.findByName(hostName);
> {code}
> Transaction chaining allow graceful rollback as well as affects visibility of
> changes to entity objects in a DB session.
> Presently a lot of chained methods have private access with @Transactional
> annotation which means the MethodInterceptor which provides the chaining
> functionality will not work and the intermediate DAO calls will persist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
