----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40674/#review107862 -----------------------------------------------------------
Ship it! Please change the branch to "trunk, branch-2.1" and link the code review from the Apache Jira. - Alejandro Fernandez On Nov. 24, 2015, 10:20 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40674/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 10:20 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-14052 > https://issues.apache.org/jira/browse/AMBARI-14052 > > > Repository: ambari > > > Description > ------- > > While doing Express Upgrade of stack from HDP 2.1 -> 2.3, the following > issues were seen for Storm. > > - Storm Config /etc/storm/conf is incorrectly pointing to > /etc/alternatives/storm-conf. > - Restarting the Storm supervisor fails (Attached Screenshot). > > Resolution : > > 1. Fixed the conf_select.py for conf symlink. In case, '/etc/storm/conf' does > have a symlink and it's not the correct one (eg: > /etc/alternatives/storm-conf), we remove the symlink and make it point to > correct symlink (eg: /etc/storm/2.3.x.y-<vesrion>/0). > 2. Fixed the Storm Supervisor failure, by adding the tasks required in > 2.1/nonrolling-upgrade-2.3.xml for "Zookeeper and Storm local data removal". > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > f0c63c6 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > a21baf1 > > Diff: https://reviews.apache.org/r/40674/diff/ > > > Testing > ------- > > - Express Upgarde from HDP 2.1 -> 2.3: Storm came up proerly. > - Service checks after upgrade ran fine. > - Stop and Start of Storm after Upgrade worked fine. > > - Unit Test: PASS (except for 9 failures already seen in : > TestPackageResource.TestPackageResource). > > > Thanks, > > Swapan Shridhar > >
