----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40682/#review107884 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py (line 106) <https://reviews.apache.org/r/40682/#comment167219> I noticed ConfigDictionary is used before it is passed to one of Resources (in this case XmlConfig). I know ConfigDictionary is to make a dictionary immutable. But Is it necessary for this use case? - jun aoki On Nov. 25, 2015, 12:54 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40682/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 12:54 a.m.) > > > Review request for Ambari, jun aoki and Oleksandr Diachenko. > > > Bugs: AMBARI-14053 > https://issues.apache.org/jira/browse/AMBARI-14053 > > > Repository: ambari > > > Description > ------- > > PXF should get secured when security is enabled on cluster via kerberos > wizard on ambari. Need to add kerberos.json and the relevant code. > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/PXF/3.0.0/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py > a4986c9 > > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py > dd0031c > > Diff: https://reviews.apache.org/r/40682/diff/ > > > Testing > ------- > > yes > > > Thanks, > > bhuvnesh chaudhary > >
