----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40688/#review108013 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (lines 243 - 244) <https://reviews.apache.org/r/40688/#comment167380> execute-stage implementation (ExecuteStage) has only one Task defined, not a list, so is the first one getting ignored now? ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml (lines 251 - 252) <https://reviews.apache.org/r/40688/#comment167382> This is incorrect for HDP-2.3.4 based on how that property is defined on the stack. - Nate Cole On Nov. 24, 2015, 8:30 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40688/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 8:30 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, Swapan > Shridhar, and Vinod Kumar Vavilapalli. > > > Bugs: AMBARI-14056 > https://issues.apache.org/jira/browse/AMBARI-14056 > > > Repository: ambari > > > Description > ------- > > HDP 2.3.4.0 has support for both AppTimelineServer v1.0 and v1.5 > The HDP 2.3 stack definition will make ATS v1.5 the default for configs. > This means that any stack upgrade that modifies the configs and upgrades to > version x where 2.3.0.0 <= x < 2.3.4.0 will fail since those binaries only > support ATS v1.0 but the configs are for ATS 1.5. > > The fix is to modify the following upgrade packs > HDP 2.1 -> 2.3 in nonrolling > HDP 2.2 -> 2.3 in both rolling and nonrolling > > So that they preserve the ATS v1.0 configs. > For tez-site, keep > ``` > tez.history.logging.service.class = > org.apache.tez.dag.history.logging.ats.ATSHistoryLoggingService > ``` > > For yarn-site, keep > ``` > yarn.timeline-service.version = 1.0 > yarn.timeline-service.store-class = > org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore > ``` > and it's ok to add the HDP 2.3 configs that are not being used, e.g., > ``` > yarn.timeline-service.entity-group-fs-store.group-id-plugin-classes = > org.apache.tez.dag.history.logging.ats.TimelineCachePluginImpl > yarn.timeline-service.entity-group-fs-store.summary-store = > org.apache.hadoop.yarn.server.timeline.RollingLevelDBTimelineStore > yarn.timeline-service.entity-group-fs-store.scan-interval-seconds = 60 > yarn.timeline-service.entity-group-fs-store.cleaner-interval-seconds = 3600 > yarn.timeline-service.entity-group-fs-store.retain-seconds = 604800 > yarn.timeline-service.entity-group-fs-store.active-dir = /ats/active/ > yarn.timeline-service.entity-group-fs-store.done-dir = /ats/done/ > ``` > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > a21baf1 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > beb316b > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 6a85479 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > ecfa031 > > Diff: https://reviews.apache.org/r/40688/diff/ > > > Testing > ------- > > Tested the following combinations on a cluster with HDFS, YARN, MR, ZK, and > NameNode HA. > > HDP 2.2.4.2 -> 2.3.2.0 > Express Upgrade without Tez > Rolling Upgrade with Tez > > HDP 2.2.4.2 -> 2.3.4.0 > Rolling Upgrade withtout Tez > Express Upgrade with Tez > > Python unit tests passed, > ---------------------------------------------------------------------- > Total run:836 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
