----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40744/#review108279 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On Nov. 26, 2015, 12:32 p.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40744/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 12:32 p.m.) > > > Review request for Ambari, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and > Yusaku Sako. > > > Bugs: AMBARI-14060 > https://issues.apache.org/jira/browse/AMBARI-14060 > > > Repository: ambari > > > Description > ------- > > - Created dynamic HTML for those settings options which are not present in > settings dropdown. > - Adding 'hive.auto.convert.join' setting to the settings list. > > > Diffs > ----- > > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/typeahead-widget.js > f9233a0 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings.hbs > 55b659a > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js > 199677d > > Diff: https://reviews.apache.org/r/40744/diff/ > > > Testing > ------- > > - manually tested > - ember test run > - No new unit test is needed. > > > Thanks, > > Pallav Kulshreshtha > >
