> On Ноя. 30, 2015, 5:09 п.п., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java,
> >  line 1190
> > <https://reviews.apache.org/r/40792/diff/1/?file=1148353#file1148353line1190>
> >
> >     Isn't HBASE_HEAPSIZE used anywhere in the env or shell script for 
> > embedded mode? Not sure why we are commenting this out.

HBase has a number of environment variables to set heapsize, HBASE_HEAPSIZE is 
just one of them. It's used by hbase shell and all HBase daemons.
To set different heapsizes for hbase shell and daemons,we use HBASE_MASTER_OPTS 
and HBASE_REGIONSERVER_OPTS for both embedded and distributed mode HBase 
daemons and HBASE_SHELL_OPTS for shell.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40792/#review108326
-----------------------------------------------------------


On Ноя. 30, 2015, 2:22 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40792/
> -----------------------------------------------------------
> 
> (Updated Ноя. 30, 2015, 2:22 п.п.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-14113
>     https://issues.apache.org/jira/browse/AMBARI-14113
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> My suspicion is the hbase shell for running the list command is taking up 
> more resources than expected.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java
>  a070935 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  b36275b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java
>  d8e7267 
> 
> Diff: https://reviews.apache.org/r/40792/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to